LCSB-BioCore / COBREXA.jl

Constraint-Based Reconstruction and EXascale Analysis
https://lcsb-biocore.github.io/COBREXA.jl/
Apache License 2.0
42 stars 8 forks source link

implement wrappy pFBA using the normal L2 wrappers #773

Closed exaexa closed 1 year ago

exaexa commented 1 year ago

@stelmo I've got 1 remaining test fail on this, which is actually on ECModel (the result is like 89% instd of 91% of some enzyme). Could you pls check what might have gone wrong? Otherwise this is IMO gtg

stelmo commented 1 year ago

Will look now, could be the solver misbehaving though

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 72.72% and project coverage change: +0.61 :tada:

Comparison is base (6a167a6) 88.02% compared to head (67bfb17) 88.63%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## mo-pfba-pipe #773 +/- ## ================================================ + Coverage 88.02% 88.63% +0.61% ================================================ Files 91 89 -2 Lines 2280 2262 -18 ================================================ - Hits 2007 2005 -2 + Misses 273 257 -16 ``` | [Impacted Files](https://codecov.io/gh/LCSB-BioCore/COBREXA.jl/pull/773?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LCSB-BioCore) | Coverage Δ | | |---|---|---| | [src/analysis/parsimonious\_flux\_balance\_analysis.jl](https://codecov.io/gh/LCSB-BioCore/COBREXA.jl/pull/773?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LCSB-BioCore#diff-c3JjL2FuYWx5c2lzL3BhcnNpbW9uaW91c19mbHV4X2JhbGFuY2VfYW5hbHlzaXMuamw=) | `80.00% <ø> (ø)` | | | [src/wrappers/SimplifiedEnzymeConstrainedModel.jl](https://codecov.io/gh/LCSB-BioCore/COBREXA.jl/pull/773?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LCSB-BioCore#diff-c3JjL3dyYXBwZXJzL1NpbXBsaWZpZWRFbnp5bWVDb25zdHJhaW5lZE1vZGVsLmps) | `78.57% <ø> (ø)` | | | [src/wrappers/MinimizeDistance.jl](https://codecov.io/gh/LCSB-BioCore/COBREXA.jl/pull/773?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LCSB-BioCore#diff-c3JjL3dyYXBwZXJzL01pbmltaXplRGlzdGFuY2Uuamw=) | `57.69% <58.82%> (+26.44%)` | :arrow_up: | | [src/wrappers/EnzymeConstrainedModel.jl](https://codecov.io/gh/LCSB-BioCore/COBREXA.jl/pull/773?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LCSB-BioCore#diff-c3JjL3dyYXBwZXJzL0VuenltZUNvbnN0cmFpbmVkTW9kZWwuamw=) | `93.02% <75.00%> (-1.85%)` | :arrow_down: | | [src/wrappers/MaxMinDrivingForceModel.jl](https://codecov.io/gh/LCSB-BioCore/COBREXA.jl/pull/773?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LCSB-BioCore#diff-c3JjL3dyYXBwZXJzL01heE1pbkRyaXZpbmdGb3JjZU1vZGVsLmps) | `94.66% <75.00%> (-1.11%)` | :arrow_down: | | [src/types/accessors/ModelWrapper.jl](https://codecov.io/gh/LCSB-BioCore/COBREXA.jl/pull/773?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LCSB-BioCore#diff-c3JjL3R5cGVzL2FjY2Vzc29ycy9Nb2RlbFdyYXBwZXIuamw=) | `57.14% <100.00%> (ø)` | | | [src/types/accessors/bits/semantics.jl](https://codecov.io/gh/LCSB-BioCore/COBREXA.jl/pull/773?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LCSB-BioCore#diff-c3JjL3R5cGVzL2FjY2Vzc29ycy9iaXRzL3NlbWFudGljcy5qbA==) | `100.00% <100.00%> (+27.45%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LCSB-BioCore). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LCSB-BioCore)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.