LCSB-BioCore / COBREXA.jl

Constraint-Based Reconstruction and EXascale Analysis
https://lcsb-biocore.github.io/COBREXA.jl/
Apache License 2.0
43 stars 9 forks source link

fix sparsevec #783

Closed exaexa closed 1 year ago

exaexa commented 1 year ago

@stelmo there are 2 other sparsevec instances in community models, can you have a look if they actually do what they are supposed to do? The problem is that sparsevec([],[],...) has defaulted to a sparse vector of Anys, which don't have a default zero, thus allocation of anything breaks.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (c510103) 91.39% compared to head (1bebba9) 91.39%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #783 +/- ## ======================================= Coverage 91.39% 91.39% ======================================= Files 86 86 Lines 2209 2209 ======================================= Hits 2019 2019 Misses 190 190 ``` | [Impacted Files](https://app.codecov.io/gh/LCSB-BioCore/COBREXA.jl/pull/783?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LCSB-BioCore) | Coverage Δ | | |---|---|---| | [src/base/types/SBMLModel.jl](https://app.codecov.io/gh/LCSB-BioCore/COBREXA.jl/pull/783?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LCSB-BioCore#diff-c3JjL2Jhc2UvdHlwZXMvU0JNTE1vZGVsLmps) | `92.75% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.