LCSB-BioCore / COBREXA.jl

Constraint-Based Reconstruction and EXascale Analysis
http://bit.ly/COBREXA
Apache License 2.0
42 stars 8 forks source link

Make duplicate reaction test stricter #787

Closed stelmo closed 1 year ago

stelmo commented 1 year ago

Takes into account reaction direction now

stelmo commented 1 year ago

/format

github-actions[bot] commented 1 year ago

:heavy_check_mark: Auto-formatting triggered by this comment succeeded, commited as cb3449bc130626306723ccd634d7e9c0951288e5

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01 :warning:

Comparison is base (3e7ea04) 89.34% compared to head (cb3449b) 89.33%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## next #787 +/- ## ========================================== - Coverage 89.34% 89.33% -0.01% ========================================== Files 92 92 Lines 2422 2420 -2 ========================================== - Hits 2164 2162 -2 Misses 258 258 ``` | [Impacted Files](https://app.codecov.io/gh/LCSB-BioCore/COBREXA.jl/pull/787?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LCSB-BioCore) | Coverage Δ | | |---|---|---| | [src/utils/Reaction.jl](https://app.codecov.io/gh/LCSB-BioCore/COBREXA.jl/pull/787?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LCSB-BioCore#diff-c3JjL3V0aWxzL1JlYWN0aW9uLmps) | `97.56% <100.00%> (-0.12%)` | :arrow_down: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

stelmo commented 1 year ago

Yep, I will :ax it shortly