search

LCSB-BioCore / FBCModelTests.jl

Tests for constraint-based metabolic models
https://lcsb-biocore.github.io/FBCModelTests.jl/stable/
Apache License 2.0
6 stars 5 forks source link

Investigate problem with reaction annotation regexes #40

Closed stelmo closed 1 year ago

stelmo commented 2 years ago

Currently the reaction annotation conformity does not work as expected (compare to output from memote.py). I think something is wrong with the regex expressions.

exaexa commented 2 years ago

example of what's wrong?

exaexa commented 1 year ago

Ping, is there an example?

stelmo commented 1 year ago

I think this may have been fixed. @Fl-Sch @vm-vh could you compare the annotation output from our tests to that of memote and see if they correspond? If so, then this is fixed

stelmo commented 1 year ago

Also add negative tests when sure that annotation checks are totally correct/can handle edge cases

stelmo commented 1 year ago

Fixed in #70