LCSB-BioCore / FBCModelTests.jl

Tests for constraint-based metabolic models
https://lcsb-biocore.github.io/FBCModelTests.jl/stable/
Apache License 2.0
6 stars 5 forks source link

Improve memote.jl #70

Closed stelmo closed 1 year ago

stelmo commented 1 year ago

Many many changes

exaexa commented 1 year ago

@stelmo pls nuke the big files from history; recommended way is to rebase -i and move the "removal" commit just below the commit that added them as a fixup.

stelmo commented 1 year ago

Nuked the big files

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 85.75% and project coverage change: -14.62 :warning:

Comparison is base (c11ca82) 95.05% compared to head (c0ea642) 80.43%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #70 +/- ## =========================================== - Coverage 95.05% 80.43% -14.62% =========================================== Files 16 20 +4 Lines 607 593 -14 =========================================== - Hits 577 477 -100 - Misses 30 116 +86 ``` | [Impacted Files](https://app.codecov.io/gh/LCSB-BioCore/FBCModelTests.jl/pull/70?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LCSB-BioCore) | Coverage Δ | | |---|---|---| | [src/memote.jl](https://app.codecov.io/gh/LCSB-BioCore/FBCModelTests.jl/pull/70?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LCSB-BioCore#diff-c3JjL21lbW90ZS5qbA==) | `100.00% <ø> (ø)` | | | [src/memote/checks/Energy.jl](https://app.codecov.io/gh/LCSB-BioCore/FBCModelTests.jl/pull/70?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LCSB-BioCore#diff-c3JjL21lbW90ZS9jaGVja3MvRW5lcmd5Lmps) | `0.00% <ø> (-89.48%)` | :arrow_down: | | [src/memote/frontend.jl](https://app.codecov.io/gh/LCSB-BioCore/FBCModelTests.jl/pull/70?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LCSB-BioCore#diff-c3JjL21lbW90ZS9mcm9udGVuZC5qbA==) | `71.60% <72.07%> (-9.94%)` | :arrow_down: | | [src/memote/utils.jl](https://app.codecov.io/gh/LCSB-BioCore/FBCModelTests.jl/pull/70?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LCSB-BioCore#diff-c3JjL21lbW90ZS91dGlscy5qbA==) | `50.00% <85.71%> (-50.00%)` | :arrow_down: | | [src/memote/checks/Reactions.jl](https://app.codecov.io/gh/LCSB-BioCore/FBCModelTests.jl/pull/70?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LCSB-BioCore#diff-c3JjL21lbW90ZS9jaGVja3MvUmVhY3Rpb25zLmps) | `95.83% <95.83%> (ø)` | | | [src/memote/checks/Annotation.jl](https://app.codecov.io/gh/LCSB-BioCore/FBCModelTests.jl/pull/70?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LCSB-BioCore#diff-c3JjL21lbW90ZS9jaGVja3MvQW5ub3RhdGlvbi5qbA==) | `100.00% <100.00%> (ø)` | | | [src/memote/checks/Basic.jl](https://app.codecov.io/gh/LCSB-BioCore/FBCModelTests.jl/pull/70?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LCSB-BioCore#diff-c3JjL21lbW90ZS9jaGVja3MvQmFzaWMuamw=) | `100.00% <100.00%> (ø)` | | | [src/memote/checks/Biomass.jl](https://app.codecov.io/gh/LCSB-BioCore/FBCModelTests.jl/pull/70?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LCSB-BioCore#diff-c3JjL21lbW90ZS9jaGVja3MvQmlvbWFzcy5qbA==) | `100.00% <100.00%> (ø)` | | | [src/memote/checks/Consistency.jl](https://app.codecov.io/gh/LCSB-BioCore/FBCModelTests.jl/pull/70?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LCSB-BioCore#diff-c3JjL21lbW90ZS9jaGVja3MvQ29uc2lzdGVuY3kuamw=) | `100.00% <100.00%> (ø)` | | | [src/memote/checks/GPRAssociation.jl](https://app.codecov.io/gh/LCSB-BioCore/FBCModelTests.jl/pull/70?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LCSB-BioCore#diff-c3JjL21lbW90ZS9jaGVja3MvR1BSQXNzb2NpYXRpb24uamw=) | `100.00% <100.00%> (ø)` | | | ... and [3 more](https://app.codecov.io/gh/LCSB-BioCore/FBCModelTests.jl/pull/70?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LCSB-BioCore) | | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/LCSB-BioCore/FBCModelTests.jl/pull/70/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=LCSB-BioCore)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

stelmo commented 1 year ago

/format

github-actions[bot] commented 1 year ago

:heavy_check_mark: Auto-formatting triggered by this comment succeeded, commited as 262bd4cc07460f89f88d59d09df22bae85e2d2db

stelmo commented 1 year ago

/format

github-actions[bot] commented 1 year ago

:heavy_check_mark: Auto-formatting triggered by this comment succeeded, commited as dfa0f8761c232f416c9a3e0fd802f135067a2d47

stelmo commented 1 year ago

/format

github-actions[bot] commented 1 year ago

:heavy_check_mark: Auto-formatting triggered by this comment succeeded, commited as 6559778429a1498a3b7fa0c4a893d33d83463924