search

LCSR-SICKKIDS / volumetric_drilling

Virtual reality for synergistic surgical training and data generation. (MICCAI 2021 AE-CAI Best Paper)
21 stars 20 forks source link

fixing voxel removed timestamps recording #17

Open nnagururu opened 6 months ago

nnagururu commented 6 months ago

Saw an incongruence between length of the voxel_time_stamp and the max index in the voxel_removed and voxel_time_stamp dataset. Realized that voxel_timestamps were being saved even when no voxels were being removed. Made minor fixes and tested; it seems to work.

adnanmunawar commented 6 months ago

Thanks for digging into this Nimesh. @jabarragann can you please look at this?

nnagururu commented 6 months ago

The change noted in this PR, was not the source of my issues, as in theory timestamps would not be published without locations and colors, as this voxels message is only published when voxels are removed.

Instead the error was from how the multiple HDF5 files were read. We should note that the timestamp index recorded in the first column of color and location is reset at the beginning of each hdf5 file. So when concatenating files, this fact must be taken into account.

However, per Adnan, we should still think through this PR request, in case there are edge cases that this PR solves.