LCSR-SICKKIDS / volumetric_drilling

Virtual reality for synergistic surgical training and data generation. (MICCAI 2021 AE-CAI Best Paper)
21 stars 18 forks source link

Incongruity between Force Wrench Length and Force Timestamp Length #18

Open nnagururu opened 5 months ago

nnagururu commented 5 months ago

Number of force timestamps exceeds number of force wrenches by varying amounts.

"This seems to be a classical case of thread synchronizination, and not using proper locks (mutex). We have a ROS callback where the data is incoming, and that is being appended to two global lists, then in another thread, we are writing this data to the HDF5 and then emptying that same lists. Since there is no synchronization / mutex here, we may have one thread add some data to one of the global list, which wasn't written to the HDF5 but was still deleted." - Per Adnan in convo with Nimesh on 4/15/24

adnanmunawar commented 5 months ago

The above commit should fix the mismatch between the size of timestamp and wrench data.