search

LD4P / arm

BIBFRAME extension ontologies for modeling bibliographic metadata in the art and rare materials domains.
https://ld4p.github.io/arm/
16 stars 11 forks source link

Review and revise ontology and vocabulary titles with a view to uniformity #118

Closed rjyounes closed 6 years ago

rjyounes commented 6 years ago

See https://github.com/LD4P/arm/issues/80#issuecomment-398461321

zimeon commented 6 years ago

BTW, the documentation generator is taking the page title for the vocabularies from the rdfs.label of the void:Dataset resource (see https://github.com/LD4P/arm/blob/master/tools/build-lode-docs.py#L48). It seems that the LODE service doesn't generate a title, perhaps because the vocabularies don't use the OWL description. I could change to get the title from somewhere else if needed

rjyounes commented 6 years ago

@zimeon I think I caught the inconsistencies you noted in https://github.com/LD4P/arm/issues/80#issuecomment-398461321; if you have time, would you mind reviewing the changes in https://github.com/LD4P/arm/commit/34009a5c00d681567a676eea4fcb199ad2607b38 to see if this is what you referred to?

Along with these changes I've added some rdfs:comments to the owl:Ontology and void:Dataset definitions. This means that when generating the documentation and temporarily converting skos:definitions to rdfs:comments, there will be two rdfs:comments. I don't know whether LODE will display one or both, and in what order - the skos:definition should be displayed first. If this doesn't work I can change them to skos:editorialNotes (though obviously I prefer rdfs:comment or I would have done so).

zimeon commented 6 years ago

Looks like those changes will make titles look better. Let me know if you'd like me to update docs

rjyounes commented 6 years ago

If it's easy, please go ahead. Then we can also see what happens with the rdfs:comments.

rdfs:label is the right place to get the dataset titles.