search

LD4P / arm

BIBFRAME extension ontologies for modeling bibliographic metadata in the art and rare materials domains.
https://ld4p.github.io/arm/
16 stars 10 forks source link

Create SHACL for Attribution Pattern #36

Open sfolsom opened 6 years ago

sfolsom commented 6 years ago

Once the conversation on Contribution vs. Activities is settled, create Attribution SHACL. https://github.com/LD4P/ArtFrame-RareMat/blob/develop/modeling_recommendations/attributions.md

rjyounes commented 6 years ago

This was developed by the Art group, so I'm not sure we need to implement it. What does @jak473 think?

rjyounes commented 6 years ago

Melanie may have already done this for the art SHACL. If so, we can borrow it.

melanieWacker commented 6 years ago

No, not yet -- I'll do it asap

melanieWacker commented 6 years ago

Added attribution pattern to art form SHACL. Please check.

rjyounes commented 6 years ago

The property shape looks good. Then you need an AttributionForm, correct?

melanieWacker commented 6 years ago

Correct. I added that into the same file.

rjyounes commented 6 years ago

Sorry, I missed it somehow.

It looks perfect. I would however remove these assertions:

rdf:type rdfs:Class ;

SHACL uses this to mean that the node shape is also a class, that is then automatically its own target class (if you then define another targetClass I think you'd have invalid SHACL, but not 100% sure). We don't want to use form shapes as target classes, so best to leave that out. I think they were in Steven's original SHACL because TopBraid was generating them.

melanieWacker commented 6 years ago

Thanks! Will take those out.