search

LD4P / arm

BIBFRAME extension ontologies for modeling bibliographic metadata in the art and rare materials domains.
https://ld4p.github.io/arm/
16 stars 10 forks source link

Physical description property groups #65

Closed rjyounes closed 6 years ago

rjyounes commented 6 years ago

@sfolsom Can we combine ItemPhysicalDescriptionPropertyGroup and InstancePhysicalDescriptionPropertyGroup into PhysicalDescriptionPropertyGroup, since only one or the other will occur on an item or instance page? Can't the label just be "Physical Description"?

rjyounes commented 6 years ago

Separate property groups have a domino effect and make it more difficult to define shared property shapes for, say, arm:markedBy - thought it can be done with sh:and - but it seems unnecessary unless the order needs to differ.

rjyounes commented 6 years ago

Need separate groups because the ordering of property shapes is different for Items and Instances - see issue #76 (now fixed and closed)