LD4P / arm

BIBFRAME extension ontologies for modeling bibliographic metadata in the art and rare materials domains.
https://ld4p.github.io/arm/
16 stars 10 forks source link

Define separate PropertyShapes for raremat_monograph_enclosure:bf_hasPart_arm_Enclosure #76

Closed sfolsom closed 6 years ago

sfolsom commented 6 years ago

Because the field generated by :bf_hasPart_arm_Enclosure will have a different sh:order depending on the Form it is used in, we need separate Property shapes for Enclosure. E.g. Because we capture responsibilityStatements and provisionActivityStatements at the Instance level the enclosure field shows up a little later in the Instance form than in the Item form.

sfolsom commented 6 years ago

When

sfolsom commented 6 years ago

When the enclosure PropertyShapes are split out we can figure out the exact order of each.

sfolsom commented 6 years ago

Please disregard comments above about responsibilityStatements and provisionActivityStatements since order happens within PropertyGroups. Still my instinct is that we will need separate PropertyShapes because we have InstancePhysicalDescriptionPropertyGroup and :ItemPhysicalDescriptionPropertyGroup and their composition and order will likely be different.

rjyounes commented 6 years ago

I've been wondering about this. In this particular case I see the need for different property groups, but in reviewing the property groups I'm often left wondering whether we could use the same group across resource types.