Open eslao opened 5 years ago
I believe Jeremy and Huda fixed this one.
This does not appear to be fixed.
https://github.com/LD4P/sinopia_editor/pull/855 was merged, but now the lookup isn't working at all
@sfolsom @eslao Can you check if this is still a problem? https://github.com/LD4P/sinopia_editor/pull/1391 fixed some issues with the Getty vocabs. I'm wondering if that resolved this issue too.
Issue #414 describes the issue with subject URIs not ending in -agent
in the new indexing approach.
[x] Please describe the expected performance and accuracy of a particular vocabulary. Expected results from Getty ULAN lookup include persons and organizations. Results do not include these, but do include items from other Getty vocabularies (materials, etc).
[x] If applicable, please update and provide links related to existing tests Test: https://github.com/LD4P/qa_server/blob/master/lib/generators/qa_server/templates/config/authorities/linked_data/scenarios/getty_ulan_ld4l_cache_validation.yml Screencap: https://docs.google.com/document/d/1UxSeZ9xWpIZ__UxzMAtJGlXUrRzY-yZ3OukZNw2FDrg/edit#heading=h.w89xtnrrvptp
[ ] If applicable, please update the relevant tab in https://docs.google.com/spreadsheets/d/1rPvEoP9iYNkxJ0eWC8gXe3ci7e6mhW0da59xkGhadi0/edit?usp=sharing for the particular dataset in question