LD4P / qa_server

A rails engine with questioning authority gem installed to serve as an authority search server with normalized results.
Apache License 2.0
5 stars 2 forks source link

New Indexing: GEONAMES - changes in accuracy tests #394

Closed elrayle closed 3 years ago

elrayle commented 3 years ago

The new indexing scheme has the following impact on GEONAMES accuracy tests:

image

sfolsom commented 3 years ago

@elrayle Do blanks mean they aren't showing up at all? Because I see https://sws.geonames.org/3017382/ as the 4th result here: https://lookup.ld4l.org/authorities/search/linked_data/geonames_direct?q=France&maxRecords=15. And https://sws.geonames.org/5128581/ is in the top 15 for (though not the 3rd position). @eichmann, it looks like we might want to weigh the value in gn:name higher. The gn:alternateName is jumping ahead in the results when it shouldn't.

elrayle commented 3 years ago

DONE Action: @sfolsom will change 'New York' search to 'New York City'

DONE Action: @elrayle will explore why 'France' does not pass while the expected URI returns as the second result.

The URI for 'France' did not end with a slash when all the other URIs did. I added the slash and the test passed.

sfolsom commented 3 years ago

Test for New York City has been made: https://github.com/LD4P/qa_server/pull/409

elrayle commented 3 years ago

DONE -- ACTION: @elrayle will push New York change to lookup-int.

All tests now pass for the new indexing approach...

image

elrayle commented 3 years ago

@eichmann The following curl requests 8 records, but gets back 1000.

curl -L -D - -H 'Accept: application/n-triples' 'http://wintermute.slis.uiowa.edu:8081/ld4l_services/geonames_batch.jsp?query=New%20York%20City&entity=all&maxRecords=8&startRecord=1&lang=en'
elrayle commented 3 years ago

Closing this as the tests now all pass. Opened Issue #413 to address the number of returned results.