search

LD4P / qa_server

A rails engine with questioning authority gem installed to serve as an authority search server with normalized results.
Apache License 2.0
5 stars 2 forks source link

New Indexing: Getty TGN - changes in accuracy tests #395

Closed elrayle closed 3 years ago

elrayle commented 3 years ago

The new indexing scheme has the following impact on GETTY_TGN accuracy tests:

image

See also Issue #414 which reports a similar issue for GETTY_ULAN which expects -agent at the end of each subject URI.

sfolsom commented 3 years ago

@eichmann this is seems to be happening on your end. No (or odd results without labels in the case of Nile River) are showing up.

elrayle commented 3 years ago

These all fail because the subject URIs are real world object URIs that end in -place.

ACTION: @eichmann will adjust the index to return the correct type URIs.

elrayle commented 3 years ago

NOTE: ULAN is similar. @sfolsom URIs need to be updated to the real world object version -person, -place, etc.

See Issue #414 which addresses the issue with ULAN.

sfolsom commented 3 years ago

Correct suffix for URIs added: https://github.com/LD4P/qa_server/pull/410

elrayle commented 3 years ago

All green on the tests. Thanks @eichmann!!!