LD4P / sinopia

LD4P Sinopia Project repo to hold docs, general issues, schemas, and related spec docs.
https://ld4p.github.io/sinopia/
19 stars 3 forks source link

Left column navigation for all sections in a record #299

Closed astridu closed 3 years ago

astridu commented 4 years ago

image

astridu commented 3 years ago

Example of field that has multiple values. image

justinlittman commented 3 years ago

@astridu How will it look if the values are long?

astridu commented 3 years ago

Good question. Could we do something like this where the text wraps until it ends, and we keep the trash/language icons right justified on the last line of text?
image

michelleif commented 3 years ago

regarding the original ticket description: this part does not seem to work: "When the section is clicked, section expands to show subsections and that form appears in the right panel" example https://development.sinopia.io/editor/completely:new

  1. scroll to field Example 18
  2. click field name in left nav
  3. expected behavior: subsection title should show in left nav. actual behavior: section title is highlighted, and that section appears in right panel, but subsection title is not shown in left nav or on right panel Screen Shot 2020-09-25 at 12.03.15 PM.png
  4. if I click "Add" in the right panel to expand, then the left nav does show the subsection Screen Shot 2020-09-25 at 12.03.52 PM.png

@astridu @justinlittman is the left nav working as expected with respect to subsections?

astridu commented 3 years ago

@michelleif I intended it would work the way you describe it in expected behavior.

justinlittman commented 3 years ago

There was some talk about automatically expanding panel properties for all panels. However, that really has nothing to do with left nav. If you'd like that done, please ticket separately.

Note that when there are defaults, this is going to mean items are automatically added to the record.

michelleif commented 3 years ago

would it make more sense if, when you click a section in the left nav, the left nav expands (if there are subsections), but the right nav doesn't expand until you click one of those subsections in left nav?

justinlittman commented 3 years ago

That would be complex to implement.

michelleif commented 3 years ago

ok. regarding expanding everything in right nav, this is documented in #300. I think it would be very useful. @astridu are we going ahead with this? (@jermnelson: this is what I was asking you about) and if so, if everything on right is expanded automatically, then is everything in left nav expanding automatically too? that might reduce the utility of left nav as an overview tool

astridu commented 3 years ago

@michelleif Having all sections expanded was definitely one of the requests at the top of the list from catalogers to reduce the amount of clicking (to open each section).

michelleif commented 3 years ago

@astridu does that mean left nav should be expanded automatically as well?

astridu commented 3 years ago

No, just the right panel. The left nav should only expand when you click on the section. This is because the left nav is for navigation, while having the right panels open enable quick data entry.

michelleif commented 3 years ago

so is this correct? 1) right panel, request enhancement: entire form (right panel) is automatically expanded (we will use existing ticket #300, updating it to be clear) 2) left nav, keep current behavior: left nav does not expand until user clicks a section

follow up: if entire form is automatically expanded, do we need a way to collapse sections? (without trashing the section)? this is discussed in ld4p/sinopia_editor#1249

astridu commented 3 years ago

Yes, thank you!

astridu commented 3 years ago

A collapse would be nice, but not necessary since we have the left nav to easily/quickly jump to the appropriate place in the form.

michelleif commented 3 years ago

closing this ticket