Closed ndushay closed 5 years ago
addendum: I just implemented getting ttl output from n3store in writeTtlFile. Now I can easily change that method to simply output a string. I will adjust this PR accordingly.
@mjgiarlo this is now a real PR. I agree there are some smells; I haven't thought of easy ways to address them. Happy to make changes; wondering about cost/benefit ratio.
@mjgiarlo this is now a real PR. I agree there are some smells; I haven't thought of easy ways to address them. Happy to make changes; wondering about cost/benefit ratio.
@ndushay OK. You raised a bunch of good questions above. Is it your preference to kick those around, or should we merge this and take up those questions in a later PR when we know more and are actively using the Sinopia server? Either of these answers are fine by me!
Given the current time crunch, and given Sandi Metz's statement rattling around in my head ("you do not have a god given right to create perfect code), I'm inclined to move forward. But if you have some quick wins, I'm happy to go for them.
Also happy to talk through stuff so we have a better knowledge share - that will be useful in and of itself, whether we proceed w refactoring or not.
@ndushay WFM!
Connects to #3 Closes #24
This is an interim PR on the way to being able to write webACL to a specific Sinopia group container. Two questions are inserted below.
Used here for tempDir for ttl files, buthave placeholders for admin webidsand initialGroupWebAcl - the baseline RDF needed for webACL for a new group.We may choose NOT to write the webACL RDF to a file before sending it to Sinopia server; I somehow convinced myself it was necessary to have the webACL as a file and have started down this path.My preference is to add the tests ensuring the ttl created from N3Store is exactly what we want to send to Sinopia server before altering course re: writing temp ttl file.(QUESTION: should we write temp files of ttl? If not, is it ok to rip it out with a later PR, or would you like it removed immediately?) - REMOVED IT.