search

LD4P / sinopia_acl

node.js based code to interact with WebACL data on sinopia server
Apache License 2.0
0 stars 0 forks source link

Refactor authentication client #49

Closed mjgiarlo closed 5 years ago

mjgiarlo commented 5 years ago

This is a small refactoring that handles validation earlier and holds on to username and password as properties of the class, which reduces the need to pass these values around. I began this refactoring when doing the work to build a tiny authN CLI yesterday, to increase my own understanding of what was going on behind the scenes. As part of the refactoring, I also made the tests smaller and more granular.

mjgiarlo commented 5 years ago

@ndushay made the curly braces change. good :eye:! will merge when :green_heart: since you have already approved.