search

LD4P / sinopia_acl

node.js based code to interact with WebACL data on sinopia server
Apache License 2.0
0 stars 0 forks source link

authenticateClient webId(cogUserName) implemented #55

Closed ndushay closed 5 years ago

ndushay commented 5 years ago

Use aws-sdk and pieces from amplify-js npm packages to get current webid given cognito username.

Requires an AWS account will appropriate permissions; happy to add more info to readme.

README shows how to run tests locally; circleci has been set up with a user so tests can pass there as well.

Bonus: switch to consistently using config.get('varname') over config.varname as I read somewhere that it was ... better for some reason.

Note that I am have created issue #56 to leverage this code in populateEmptyTrellis

closes #29

ndushay commented 5 years ago

I believe coverage stats are ok -- I only wrote test for happy path, but in the course of debugging, I empirically showed at least one non-happy path did the right thing.

mjgiarlo commented 5 years ago

Not fussed about test coverage.

ndushay commented 5 years ago

Great suggestions, Mike. Thanks.