cognito: send only one confirmation email (instead of 4) when someone signs up for cognito - Githubissues

LD4P / sinopia_acl

node.js based code to interact with WebACL data on sinopia server

Apache License 2.0

0 stars 0 forks source link

cognito: send only one confirmation email (instead of 4) when someone signs up for cognito #57

Closed ndushay closed 3 years ago

ndushay commented 5 years ago

Our current ACL approach depends on having a way of knowing who is signing up for a cognito account. This may be set up in terraform already, but @michelleif is not getting emails (for dev).

Definitely want to get emails for prod, and possibly for stage as well.

[x] can the email subject distinguish between prod, stage and dev environment? (unchecking this because the email subject does not say what environment it's coming from)
[x] use sinopia_admin@stanford.edu as email ~~@michelleif's call: should these emails go to a list? Seems like a bad "truck factor" situation if they only go to your personal email.~~
[x] text of emails ok
[x] subject of emails ok
[x] works on dev
[x] works on test
[x] works on prod

michelleif commented 5 years ago

have emails go to sinopia_admin@stanford.edu

rsmith11 commented 5 years ago

Is sinopia_admin@stanford.edu an email list? Typically email lists created by the campus mailman service include an @lists.stanford.edu in the name.

michelleif commented 5 years ago

no, it's not a list. it's a shared email that's gets forwarded to me and Jeremy. Jeremy, Darsi and I are administrators of the workgroup that manages the shared email so any of us can add additional forwardees.

rsmith11 commented 5 years ago

Thanks for the clarification. I'll be sending an email verification from Amazon AWS SES service shortly to confirm that email address. Once it's confirmed, then I can configure AWS to send email from that email address.

rsmith11 commented 5 years ago

I just made some changes in development and did a test user creation. Let me know if you did or didn't receive an email confirmation.

michelleif commented 5 years ago

I got the email but it says "Please add them to the necessary group in Trellis." We decided that I don't need to add users to groups in Trellis right? The email is just for informational purposes?

rsmith11 commented 5 years ago

That is some old text that I wrote up. If you'd like it changed, let me know what you want it changed to then I'll update the Lambda code that sends it.

michelleif commented 5 years ago

the text of the email has been revised by https://github.com/LD4P/sinopia/issues/203

why is "can the email subject distinguish between prod, stage and dev environment?" checked off? the email I get from PRD and from DEV just says "Sinopia User Registration". No indication of environment.

michelleif commented 5 years ago

bug: I get 4 separate (but identical) confirmation emails (instead of one) sent to me at the same time when a user creates a new account on PRD. I get 3 separate (but identical) confirmation emails (instead of one) sent to me at the same time when a user creates a new account on DEV.

michelleif commented 5 years ago

we decided this is future technical debt and not important for M3 (the multiple emails, that is)

michelleif commented 3 years ago

I am only receiving one email now. closing.