search

LD4P / sinopia_acl

node.js based code to interact with WebACL data on sinopia server
Apache License 2.0
0 stars 0 forks source link

Update version to 1.0.0 #82

Closed jermnelson closed 4 years ago

jmartin-sul commented 5 years ago

@jermnelson, not sure why the build is failing all of a sudden on that change, though IIRC, i've seen that before when running the code locally.

at any rate, might be worth putting those env vars in circle, to be safe, and filing a ticket to figure out why it's an issue (since my recollection was that those settings should have defaults if the env vars aren't present). if putting the env vars in circle doesn't work, i guess more investigation will be needed?

i'm also thinking i'll have a small PR up related to LD4P/sinopia#224 this afternoon/evening, so i could just bump the version as part of that, and investigate this build failure as part of that, since i expect to tweak a couple small things around the default admin user as part of that work. i could just bump the version as part of that, if you don't mind sinopia_acl briefly lagging the editor and the other codebases in terms of version number.

jermnelson commented 5 years ago

@jermnelson, not sure why the build is failing all of a sudden on that change, though IIRC, i've seen that before when running the code locally.

at any rate, might be worth putting those env vars in circle, to be safe, and filing a ticket to figure out why it's an issue (since my recollection was that those settings should have defaults if the env vars aren't present). if putting the env vars in circle doesn't work, i guess more investigation will be needed?

i'm also thinking i'll have a small PR up related to LD4P/sinopia#224 this afternoon/evening, so i could just bump the version as part of that, and investigate this build failure as part of that, since i expect to tweak a couple small things around the default admin user as part of that work. i could just bump the version as part of that, if you don't mind sinopia_acl briefly lagging the editor and the other codebases in terms of version number.

Thanks John, if you could investigate this, that would be great. We're not blocked on releasing 1.0.0 in the editor. As a background task, I'm creating tagged versions for all of the supporting code-bases in Sinopia

jmartin-sul commented 5 years ago

filed https://github.com/LD4P/sinopia_acl/issues/85

will leave this open for now.