Close and save buttons not closing/saving open tab

[fculpepper]

What went wrong? When saving, I get confirmation of the save but when closing am told that there is unsaved information. And, when clicking the Close button, the leftmost resource template is closed, not the one that is open. What did you expect to happen? I expect the RT that I am working on to save when I press the save button and close when I press the close button.

• What is the impact on your work? Really super annoying.
• What environment are you in? production
• What OS and browser are you using? Windows; Firefox
• If you're cataloging, what Resource Template were you using? UAL Monograph Opus (Un-Nested), UAL Monograph Work (Un-Nested), UAL Monograph Instance (Un-Nested) and UAL Monograph Item (Un-Nested)

Please include a screenshot

[peetucket]

See also #2052 -- this is basically the same thing I believe

[michelleif]

2052 is closed now. @fculpepper are you still seeing this bug?

[briesenberg07]

Just commented on similar issue #2052 .

[michelleif]

@fculpepper new version of Sinopia released today that should fix the erroneous message about unsaved info. Can you check if that is fixed? Are you still seeing the problem with closing the wrong tab? (that is also documented in #2183

[jermnelson]

Adding a new wrinkle to this bug as it is related to issues with closing/saving the correct tab.

To replicate (when running locally with in USE_FIXTURES=true):

1. Open a resource template like ld4p:RT:bf2:Title:AbbrTitle and add some content:
2. Open a second resource (do not close the previously opened resource template) like resourceTemplate:bf2:Note:
3. Click on the close button for the first resource template, a pop-up confirmation modal is displayed as expected:
4. However, if you click on the blue close button, the
   ld4p:RT:bf2:Title:AbbrTitle tab is not close but instead the tab with the resourceTemplate:bf2:Note resource template is closed, leaving the original resource template:

[michelleif]

This seems to be happening again. (examples are on stage)

I have three templates open. One is a template that I entered some data into "A form about a thing". The other two are resource templates I opened but have not touched, both tabs called "Resource Template".

I close the current highlighted tab and it works as expected. Now I have two tabs.

Now I want to close the "A form about a thing" tab. So I close it by clicking the little "x", while staying on "Resource Template", and am prompted, as expected, to save the unsaved changes.

I don't want to save, so I just click "Close".

Now I have one template standing, but it's not the one I was on before called "Resource Template". It's the one I tried to close called "A form about a thing"

[jermnelson]

@michelleif I think this bug was fixed with Justin's recent merged PR #2780. I tested on dev but we should test again on stage after Monday's dependency updates (which should include Justin's PR)

[michelleif]

tested on DEV just now and this is fixed.