LD4P / sinopia_editor

Sinopia Linked Data Editor

https://sinopia.io/

Apache License 2.0

35 stars 10 forks source link

Visual design: left nav #3083

Closed astridu closed 3 years ago

astridu commented 3 years ago

Expand/collapse control on the left
~~Dot on the right indicates whether content has been entered for that field~~ Moved to #3100
Expanded properties and all properties nested under it are black.
~~If user clicks 'Save' and required fields are not entered, they will display in red to indicate they need to be filled in.~~ Moved to #3122
Collapsed properties are in blue.
~~Is there any opportunity to save what the user has expanded/collapsed so the next time the resource is opened, the same properties are expanded/collapsed?~~ Moved to #3084

jcoyne commented 3 years ago

@astridu This is a bit too abstract for me to implement. Can you demonstrate this with real properties that we can see in stage?

It's also a bit large for one ticket. Can you split this into one ticket for the new hierarchy and one for marking properties as being entered?

astridu commented 3 years ago

Does this help?

jcoyne commented 3 years ago

Yes, this is much easier to understand. Thanks for doing the extra work @astridu

jcoyne commented 3 years ago

Developers; It looks like this removes the btn-primary class from the sidebar. When this happens, also remove it from resourceNav.scss and remove $vanilla from colors.scss

jcoyne commented 3 years ago

@astridu can you add what the top-level items in the left nav should look like if they don't expand? See this example using: https://stage.sinopia.io/editor/ld4p:RT:bf2:Monograph:Item:Un-nested

Screen Shot 2021-10-07 at 10.21.29 AM.png

astridu commented 3 years ago

In this case, it would have have the expand/collapse control. Selected property would be bold, black. Other properties would be bold, blue. Black dot to the right to indicate if it's filled in.

jcoyne commented 3 years ago

@astridu I'm looking for a mockup that mixes in the expand controls with those that don't get expand controls. How should those be positioned when we have a mix of hierarchical and non-hierarchical?

astridu commented 3 years ago

Like this?

jcoyne commented 3 years ago

@astridu Yes, thank you.

jcoyne commented 3 years ago

3138 has the new UI, but the tests need to be updated. I'm FR this week so I don't think I'll get back to this. Please take over my PR branch if it's helpful.