search

LD4P / sinopia_editor

Sinopia Linked Data Editor
https://sinopia.io/
Apache License 2.0
35 stars 10 forks source link

prod code shouldn't do imports from static/spoofedFilesFromServer directory #719

Closed ndushay closed 5 years ago

ndushay commented 5 years ago

per discussion in PR #702:

Whatever we need from the spoofing directory, for production, should be moved into a more appropriate directory/class.

The spoofing code can use it from the new location, and the prod code can also use it from the new location.

This will be the separation of "spoof" from "config stuff we actually are using in prod".

See:

If it is simple to do, consider #457, too. (Or just move "lookupConfig" file to new dir)

michelleif commented 5 years ago

what's the new address of the config? cause i refer to it on this help page: https://github.com/LD4P/qa_server/wiki/Authority-Lookup-Support-Plan-for-Sinopia pls tell me when this is going to be changed so I can update that page

ndushay commented 5 years ago

@michelleif new home is now here: https://github.com/LD4P/sinopia_editor/blob/master/static/lookupConfig.json