search

LD4P / sinopia_server

[Deprecated - switching to MongoDB] Sinopia Back-end CRUD Service. LDP-inspired, HTTP Server taking JSON-LD resources & administrative metadata.
Apache License 2.0
1 stars 1 forks source link

JS client improvements #21

Closed jmartin-sul closed 5 years ago

jmartin-sul commented 5 years ago

note: tests currently hardcoded to expect trellis to be running on http://localhost:8080 (:8081 for /healthcheck). we'll prob need to fix that to play nicely with CI (edit: and indeed, this is breaking the build).

closes #10

cmharlow commented 5 years ago

lgtm. testing the client code now with trellis running locally. wondering what to do about the failing test.

jmartin-sul commented 5 years ago

@cmh2166 said:

wondering what to do about the failing coverage test

i think i need to work with @atz to fix the tests so that they can take a <hostname>:<port> that works for circle. i was already figuring that the hardcoded localhost was a hack that'd have to go.

cmharlow commented 5 years ago

@cmh2166 said:

wondering what to do about the failing coverage test

i think i need to work with @atz to fix the tests so that they can take a <hostname>:<port> that works for circle. i was already figuring that the hardcoded localhost was a hack that'd have to go.

yeah, that makes sense, i saw your comment on hardcoding above. have you and @atz gotten further on the orchestration questions around where to deploy trellis (and possibly have the swagger spec there, with the client code eventually going into front end codebases)/

jmartin-sul commented 5 years ago

we've discussed it some, but i don't think we came up with any clear answers yet. i just pinged him on slack to try to pair for a bit this afternoon on it.

acoburn commented 5 years ago

FYI with this commit (https://github.com/trellis-ldp/trellis-ext-db/commit/497144deaa09ab43aa90f78f92fd8e4eb1ccaef9) you can now set the Trellis HTTP port with an environment variable such as: TRELLIS_HTTP_PORT=9999 and/or TRELLIS_ADMIN_HTTP_PORT=9998

jmartin-sul commented 5 years ago

ok, i cleaned up the commits to get a passing CI build using the nascent swagger-codegen based tests.

left to do:

jermnelson commented 5 years ago

Hi John, looks good to me. Made some minor comments but nothing blocking. Do you think this client code should be an imported node module by the Sinopia Editor for making API calls?

Thanks, Jeremy

jmartin-sul commented 5 years ago

@jermnelson or @ndushay, might i get one of you to merge if there are no objections? or to at least approve so this doesn't look like a totally unwarranted self-merge? 😁