search

LD4P / sinopia_server

[Deprecated - switching to MongoDB] Sinopia Back-end CRUD Service. LDP-inspired, HTTP Server taking JSON-LD resources & administrative metadata.
Apache License 2.0
1 stars 1 forks source link

make sure we've spec'ed getResource properly #56

Closed jmartin-sul closed 5 years ago

jmartin-sul commented 5 years ago

make sure the getResource method from the sinopia_client SDK behaves as desired, since this will likely be the thing the now-in-progress indexing daemon uses to ask trellis for the content it will be indexing (#55).

jmartin-sul commented 5 years ago

we have a test for non-RDF resources, just need to make sure we have this for RDF resources.

turns out the indexing pipeline doesn't need this for now (may later), but the editor will.

for RDF resources, this may involve making sure the return type for the operation has a structure that matches what we might get back from trellis, so that we can try to use getResource to parse the response automatically.

if getting that return type right is a total pain, we can prob just use getResourceWithHttpInfo and use the JSON we get back in the responseAndData.response.body field and call it a day.

ndushay commented 5 years ago

@jmartin-sul should this issue be M4?

jmartin-sul commented 5 years ago

@ndushay, that sounds reasonable to me

ndushay commented 5 years ago

@jermnelson wanna make this M4?

jermnelson commented 5 years ago

@jmartin-sul and @ndushay are there specific tests that are needed to close this issue for M4? Otherwise, can we consider changing the label to debt and add to work-cycle 2 project? Thanks!

jmartin-sul commented 5 years ago

turns out this is done!

https://github.com/LD4P/sinopia_server/commit/195cd17b67181d1793e390f7ddad778d587e43d4#diff-9c98b1f96912899c02b40c5bb91a07dcR269

closing...