search

LD4P / sinopia_server

[Deprecated - switching to MongoDB] Sinopia Back-end CRUD Service. LDP-inspired, HTTP Server taking JSON-LD resources & administrative metadata.
Apache License 2.0
1 stars 1 forks source link

Authentication tests and touchups #77

Closed jmartin-sul closed 5 years ago

jmartin-sul commented 5 years ago

~build is failing because the ld4p/trellis-ext-db docker image with proper JWT configuration isn't available. i have that locally, will get that built/tagged/pushed to dockerhub tomorrow.~ That was a red herring. The issue was that the two Cognito-related environment variables Trellis needs to have the config point to the right JWKS were hardcoded to stale values (another env var was no longer needed since it specified what is now the default in config.yml, enabling JWT auth). I pushed a follow-on commit that allows the environment running docker-compose to specify overriding values for the Cognito environment variables (and I fixed the values for both the docker-compose.yml defaults and the Circle-specified overriding values; if things fall out of date, only the circle values need fixing to get the build to pass again).

Of course, the latest ld4p/trellis-ext-db still needs pushing to dockerhub for other consumers (when using this repo's docker-compose.yml as its Circle build does, the image is re-built as needed from local Dockerfile, as specified by the build section of docker-compose.yml).

closes #73

jmartin-sul commented 5 years ago

i suspect that #85 will get merged first, and that this will require rebasing on master after that

jmartin-sul commented 5 years ago

if this one gets merged before #85 afterall, happy to rebase that one as needed. don't particularly care about the ordering between the two.

jmartin-sul commented 5 years ago

(FYI, naomi deferred on merging, wanted a second set of eyes to review)