ThomasGalesloot
commented
1 year ago Looks good.
Only one nitpick. Are the extra input files required in the testing suit, if not could we have them removed? Example ERA5_2020_2020_Canada_2xRes.nc.
Good catch - No they are not I just got lazy with this test and instead of making a new inputs subfolder for the test I just created the test from my highest level inputs folder
Pull Request Key Information
Reason for change
A bug was discovered where proportions were not being properly done by site rate but instead by recency.
What was changed
Proportioning is now properly done as the top percent of sites by rate.
Intended Purpose
Bugfix
Level of version change required
Minor - to version 3.3
Testing Completed
All End to End and unit testing passed: [Uploading Test_results_57323e24576a54640f79230ae9381d77b66f1906.zip…]()
Target Issue
N/A
Additional Information
N/A