LDAR-Sim / LDAR_Sim

MIT License
11 stars 22 forks source link

Incorrect Survey Times when using 2 mobile methods deployed simultaneously #126

Closed ThomasGalesloot closed 1 year ago

ThomasGalesloot commented 1 year ago

Bug/Defect description

This bug occurs when a modelled program contains 2 methods both parameterized as mobile methods that survey sites at the same time,. It is most prominent with survey times close to 1/3-1/2 of a day. What occurs is that the modelled survey times are higher than they should be.

For example: with 2 identical mobile methods that have no scheduling limitations, a survey time of 240 minutes (4 hours), with a travel time of 30 minutes for 4 sites and an RS of 1 surveys per year, each method is expected to spend a total of 240*4 = 960 minutes surveying each time all sites are surveyed.

What will instead be observed is that both method have a variation from the expected survey times in the timeseries, such as 1050 minutes of survey time per year for the first method and 870 hours of surveying per year for the second method

Steps to reproduce

Use the parameter supplied below along with sample inputs files present in the LDAR-Sim inputs directory. Observe the M_OGI_survey time and M_OGI_copy_survey time in the timeseries output (This is best done by creating a pivot table using date vs sum of x_survey_time from the timeseries output).

Alternatively parameterize any 2 mobile methods that will be conducting surveys at the same time.

Evidence

image

Expected behavior

The sum of survey times for each year should be 960 minutes.

Inputs and Parameters

Sample_Parameters_to_Reproduce_Issue.zip

Version Number

V3.3.1

Additional Context

No response