search

LDAR-Sim / LDAR_Sim

MIT License
11 stars 22 forks source link

Prevent pandas concat warning #148

Closed SEAJang closed 8 months ago

SEAJang commented 9 months ago

Pull Request Key Information

Reason for change

The update to pandas 2.1 added a new FutureWarning error for when concatenating Nulls or N/A columns.

What was changed

Changed logic from concatenating new rows to filling out the data of a pre-initialized dataframe

Intended Purpose

Address the FutureWarning caused by Pandas.

Level of version change required

N/A

Testing Completed

Manual testing of the results (n_simulation tested at 3,5,6,10,12, and 15)

Additional Information

Include any other important information here.

SEAJang commented 8 months ago

Will squash and merge - to clean up the version history

SEAJang commented 8 months ago

The test results of comparing the LDAR-Sim-V4-Emissions-Rework branch output files with the output from this branch.

compare.txt

Shows that the outputs generated are not changed by this update.