LDAR-Sim / LDAR_Sim

MIT License
11 stars 22 forks source link

V4 preseed random fix #149

Closed SEAJang closed 8 months ago

SEAJang commented 8 months ago

Pull Request Key Information

Reason for change

Setting the random seed function was not working as intended.

What was changed

The random seeds are now utilized, and simulations can be replicated if users provide the pre-seed files.

Intended Purpose

To allow for users to replicate simulations as long as they have the pre-seed generator files.

Testing Completed

Output files were manually compared using https://www.diffchecker.com/ First set of outputs were made by sims ran normally with no generator files Second set of outputs were made by sims ran with existing generator files Third set of outputs were generated by sims that had only the pre-generated seed files (preseed.p and emis_preseed.p) Fourth set of outputs were generated by changing the version number in the parameters.

The following zip contains the files necessary to replicate the test mentioned above. simple_test_case.zip

Shows the expected identical emissions summary file from the first vs fourth set of outputs image

Shows the expected 8 lines of differences from the change in versions from the first vs fourth parameter file image