LDAR-Sim / LDAR_Sim

MIT License
11 stars 20 forks source link

Intermittent Emissions Functionality #204

Closed ThomasGalesloot closed 3 months ago

ThomasGalesloot commented 3 months ago

Pull Request Key Information

Reason for change

Previously, the parameters indicating the intermittency of emissions were propagated down as source parameters, but were unused. Intermittency functionality for emissions was desired.

What was changed

This change enables sources to create intermittent emissions and adds two new emission types: intermittent_repairable_emission and intermittent_non_repairable_emission. These emission types inherit from the repairable and non-repairable emission types, respectively, and implement intermittency functionality through a mixin class.

Intended Purpose

Add ability to model intermittent emissions

Level of version change required

N/A

Testing Completed

All units tests pass: unit_test_results.txt

New functionality is thoroughly unit tested.

Performed a manual test using simple_test_case_1 parameter with the following modified virtual world and infrastructure files and evaluation single simulation results. Evaluation is also attached - see final 2 columns.

Test Inputs and evaluation: Intermittency Test Inputs and Manual Evaluation.zip

Target Issue

N/A

Additional Information

Documentation will be incorporated as part of a different change.