LDAR-Sim / LDAR_Sim

MIT License
11 stars 22 forks source link

Quantification update #207

Closed ThomasGalesloot closed 5 months ago

ThomasGalesloot commented 5 months ago

Pull Request Key Information

Reason for change

Previous quantification logic was restrictive in it's assumptions and what could be modelled, and did not account for possible quantification bias.

What was changed

Removed hardcoded implementation of quantification type, now allowing users to provide a quantification type as a parameter. Changed quantification error related inputs to allow for a simple representation of quantification bias and to be easier to acquire. Changed design structure to facilitate the implementation of further quantification modules in the future, including by users.

Intended Purpose

To update the existing quantification error implementation to allow for representation of quantification bias, improve usability and facilitate modification of quantification functionality by users (ie: Allow users to more easily replace existing quantification logic with their own quantification module.)

Level of version change required

N/A

Testing Completed

Manual testing with inspect of Quantification testing.zip outputs - See a sample output and changes made to simple simulation 1 to get results.

All unit tests pass, including new unit tests: unit_test_results.txt

Target Issue

N/A

Additional Information

N/A

ThomasGalesloot commented 5 months ago

Latest set of unit testing after rebase: unit_test_results.txt Also ran simple test case 1 to verify nothing high level broke