search

LDAR-Sim / LDAR_Sim

MIT License
11 stars 22 forks source link

V4 deploy true/false table #209

Closed SEAJang closed 5 months ago

SEAJang commented 5 months ago

Pull Request Key Information

Reason for change

Part 1 of a set of changes needed to allow for a better estimate when only deploying at part of the full infrastructure.

What was changed

Added additional column to the estimated_emissions.csv that provides a True/False value on if the given site has been measured or not, and the site_type. Fixed a bug where the site_type was not making it into the Site initialization.

Intended Purpose

Part one of a set of changes.

Testing Completed

Added unit tests for the relevant new functions. All unit tests pass. results.txt

Did not unit test the join of the produced dataframe with the output dataframe, as it was just a single pandas join function and the output could be checked with the csv.

Ran the simple simulation case 1 which had stationary, OGI and follow-up methods.

SEAJang commented 5 months ago

Reran simulation.

All unit tests pass. results.txt