LDAR-Sim / LDAR_Sim

MIT License
11 stars 20 forks source link

fix: Fix bug with equipment group survey scaling #235

Closed ThomasGalesloot closed 2 months ago

ThomasGalesloot commented 2 months ago

Pull Request Key Information

Reason for change

Survey times and cost were not being properly proportionally propagated down when using equipment groups. This resulted in inflated survey times and costs when using equipment groups.

What was changed

Survey times and costs are now properly scaled down when using equipment groups. This is done by scaling the survey times and costs of the equipment group by the number of equipment groups.

Intended Purpose

Equipment group survey times and costs are now fixed and properly functioning.

Level of version change required

Patch to next patch version

Testing Completed

Manual testing.

All unit tests passing: unit_test_results.txt

Target Issue

N/A

Additional Information

N/A

ThomasGalesloot commented 2 months ago

Manual testing after rebase remained successful

Unit testing after rebase all passes: unit_test_results.txt