search

LDAR-Sim / LDAR_Sim

MIT License
11 stars 20 forks source link

Bug fix - Per day costs #237

Closed SEAJang closed 2 months ago

SEAJang commented 2 months ago

Pull Request Key Information

Reason for change

Per day costs were being added daily, even when no deployments were happening.

What was changed

Fixed such that deployments impact the per day costs.

Intended Purpose

Fix bug related to per day costs not working as intended.

Level of version change required

Patch

Testing Completed

Added new unit tests All existing unit tests pass. results.txt

Manually ran simple_test_case1, with a method that had a per_day cost set, and one without to ensure that both are working as intended. image

SEAJang commented 2 months ago

Unit test results (all pass) results.txt Manually tested stationary deployment costs, and mobile per day deployment costs, and ensured that the per site costs were not affected. image image

SEAJang commented 2 months ago

All unit tests pass results.txt

Manually tested again. image image

SEAJang commented 2 months ago

All unit tests pass results.txt

Manually tested again image

SEAJang commented 2 months ago

All unit tests pass results.txt

Manual testing looked good.