LDAR-Sim / LDAR_Sim

MIT License
11 stars 20 forks source link

<FEAT>Implement the duration estimation ratio value #250

Closed SEAJang closed 2 months ago

SEAJang commented 2 months ago

Pull Request Key Information

Reason for change

The duration estimation ratio existed as a placeholder and functionally did not do anything

What was changed

The functionality for duration estimation ratio was implemented

Intended Purpose

Allow users to customize the duration estimations used by the uncertainty measurements

Level of version change required

Minor

Testing Completed

New unit tests were added All unit tests pass results.txt

Manual testing was completed - specifically looking at when the ratio is set to 0.0 and 0.5 - 0.0 exaggerated the existing bugs significantly.

Target Issue

Closes #224

Additional Info

Several warnings have been introduced with the update of the pandas library. A new issue will be created to address these warnings. Tagging to update this to V4.1.0 will happen after this PR has been approved.

SEAJang commented 2 months ago

results.txt Unit test results after rebasing on the current head of master.