LDAR-Sim / LDAR_Sim

MIT License

11 stars 20 forks source link

<FIX>: Properly update the site list for sites considered for follow-ups and in queue for follow-up #253

Closed SEAJang closed 2 months ago

SEAJang commented 2 months ago

Pull Request Key Information

Reason for change

The dictionary for considering sites for flagging was set up to be used but never populated

What was changed

site candidates for flagged should no longer be endlessly added to the candidate pool

Intended Purpose

Fix the incorrect follow-up behavior

Level of version change required

Patch

Testing Completed

Manually tested the behavior All unit tests pass. results.txt

SEAJang commented 2 months ago

Simple test to duplicate - used stationary method with a follow-up delay of 120 days. Below is an example timeseries output that shows flagging happening at 220 sites, when virtual world only has 50 sites total.

SEAJang commented 2 months ago

Output with change: