LDAR-Sim / LDAR_Sim

MIT License
11 stars 20 forks source link

[BUG] Enhancement needed for repaired emissions consideration for emissions estimation #257

Open SEAJang opened 2 months ago

SEAJang commented 2 months ago

Bug/Defect description

Negative emissions can be observed in the "Emissions Summary" for "Yearly estimated emissions".

Steps to reproduce

This situation occurs when measurements are taken frequently. If a new emission is detected and measured between the tagging and repair of an initial emission at a site, this new emission will be tagged for future repair. However, if the measurements following this tagging do not detect the new emission because it falls below the Minimum Detection Limit (MDL), the newly tagged emission might go unreported in the latest measurement reports since the original emissions have already been repaired.

See the following image for a graphical representation. image

Evidence

Emissions Summary: image Estimated Repaired emissions to remove, filtered for the particular year of 2025 image Emissions summary filtered for the particular year of 2025 image Estimated emissions, filtered by the year, only result in measured rates of 0 image

Expected behavior

Fugitive emissions that are tagged for repairs

Inputs and Parameters

simple_test_case_1_inputs.zip simple_test_case1_parameter.zip

Version Number

V4.1.0

Additional Context

A fix will be implemented to default any negative values to 0, however, it is recommended a design enhancement to improve the handling of this situation.