LDAR-Sim / LDAR_Sim

MIT License
11 stars 22 forks source link

<FIX>: Fix estimated emission to be min.0 #258

Closed SEAJang closed 3 months ago

SEAJang commented 4 months ago

Pull Request Key Information

Reason for change

It was still possible to get negative emissions observed in the emissions summary for yearly estimated emissions.

What was changed

Fix such that if the estimated emissions is smaller than the fugitives to remove, the estimated is set to 0.

Intended Purpose

Prevent negatives from being observed as an emission estimate.

Level of version change required

Patch

Testing Completed

Manually tested - the following is the new Emissions Summary output. See #257 for original output, input and parameter files image Same emissions as before still exists: image

All unit tests pass. result.txt

Target Issue

Linked to #257 -> see this issue for more details

Additional Information

Include any other important information here.