search

LDAR-Sim / LDAR_Sim

MIT License
11 stars 20 forks source link

perf: Improve Survey Results Memory Usage #268

Closed ThomasGalesloot closed 2 months ago

ThomasGalesloot commented 2 months ago

Pull Request Key Information

Reason for change

During the memory profiling, the results of surveys were found to be taking up over 70% of the memory allocated during simulation.

What was changed

This change reduces the memory usage of survey results, resulting an approximately 97% decrease in memory allocated during simulation in the case being tested.

Intended Purpose

Lower memory usage during simulation.

Level of version change required

Patch

Testing Completed

Manual testing with memory profiling - See Sample results here: memory_profiling_results.zip

All unit tests passing: unit_test_results.txt

All End-to-End tests passing: V4_simple_non_repairable_emissions_df7cdf012ba7c4aef1dbd54e02f1f18bd9b0bfa3.log V4-simple_repairable_emissions_df7cdf012ba7c4aef1dbd54e02f1f18bd9b0bfa3.log

Target Issue

N/A

Additional Information

N/A

ThomasGalesloot commented 2 months ago

New unit test results: unit_test_results.txt

New End-to-End test results: V4_simple_non_repairable_emissions_c67e910bf3e029273da17ce6bfa5a0ae997f9839.log V4-simple_repairable_emissions_c67e910bf3e029273da17ce6bfa5a0ae997f9839.log