LDAR-Sim / LDAR_Sim

MIT License
11 stars 20 forks source link

QE initialization bugfix #273

Closed SEAJang closed 2 months ago

SEAJang commented 2 months ago

Pull Request Key Information

Reason for change

Original code did not add in handling when NaN values were read in. This resulted in measurements turned to NaN when quantification error is factored in, as NaN * any value = NaN.

What was changed

Adjust the initialization/handling of the quantification error values when samples are used.

Intended Purpose

Fix the issue where measurements would result in NaN due to invalid QE being used to multiply "measured rate".

Level of version change required

Patch

Testing Completed

New unit tests were added, all existing unit tests pass. results.txt

Manually tested to see that the behavior is gone.

All E2E tests are passing. V4_simple_non_repairable_emissions_e3c3306d590233f92ae887ddd9e48c39452b5d10.log V4-simple_repairable_emissions_e3c3306d590233f92ae887ddd9e48c39452b5d10.log

Target Issue

Put GitHub keywords to link the pull request to the target issue here. For example: Closes #XX.

Additional Information

Include any other important information here.