LDAR-Sim / LDAR_Sim

MIT License
11 stars 20 forks source link

<UPD>: Update how generate emissions pre-generates #276

Closed SEAJang closed 1 month ago

SEAJang commented 1 month ago

Pull Request Key Information

Reason for change

The emissions that are generated for pre-sim start date were not ordered correctly

What was changed

Intended Purpose

Update the code such that the emissions are generated based on oldest date first

Level of version change required

Patch

Testing Completed

All unit tests pass - old and new results.txt

The E2E tests have been updated to reflect the new generate emissions changes. V4_simple_non_repairable_emissions_300e5ec164c2571e1d50afdafe37c6ce2d1ad8a3.log V4-simple_repairable_emissions_300e5ec164c2571e1d50afdafe37c6ce2d1ad8a3.log

Target Issue

Put GitHub keywords to link the pull request to the target issue here. For example: Closes #XX.

Additional Information

Include any other important information here.

ThomasGalesloot commented 1 month ago

Was this a bug or is this a change?

SEAJang commented 1 month ago

Was this a bug or is this a change?

It was a change. Previously the dates for the pre-sim start went from newest to oldest, and then all emissions after that went from oldest to newest. now it's constant oldest to newest.

ThomasGalesloot commented 1 month ago

Does either activate emissions or emissions logic around pre-simulation emissions need to be updated as part of this change?

SEAJang commented 1 month ago

Does either activate emissions or emissions logic around pre-simulation emissions need to be updated as part of this change?

Nope.