LDAR-Sim / LDAR_Sim

MIT License
11 stars 20 forks source link

feat: Refactor end-to-end test case creator script #284

Closed ThomasGalesloot closed 1 month ago

ThomasGalesloot commented 1 month ago

Pull Request Key Information

Reason for change

The End-to-End test case creator script was long, hard to maintain and did not share code with other scripts that "run" LDAR-Sim.

What was changed

Refactored the end-to-end test case creator script to use an end-to-end test case creator simulation manager that inherits core functionality from the base simulation manager.

Intended Purpose

This allows the end-to-end test case creator to inherit changes made to LDAR-Sim run functionality.

Level of version change required

N/A

Testing Completed

All unit tests pass: unit_test_results.txt

All E2E tests pass: V4_simple_non_repairable_emissions_bb24139aabd09018a0ce99ce324c10cdab0c31b8.log V4-simple_repairable_emissions_bb24139aabd09018a0ce99ce324c10cdab0c31b8.log

Comparison of file names between master and this branch is identical (Actual file contents will not be because E2E creator script forces remake of generator files): E2E creator testing.zip

Sample E2E test case created using latest from script passes: new_bb24139aabd09018a0ce99ce324c10cdab0c31b8.log

Target Issue

N/A

Additional Information

N/A

ThomasGalesloot commented 1 month ago

New E2E test results: test_1db583486dfeb63dd0273ccbeda9773ab180d09d.log V4_simple_non_repairable_emissions_1db583486dfeb63dd0273ccbeda9773ab180d09d.log V4-simple_repairable_emissions_1db583486dfeb63dd0273ccbeda9773ab180d09d.log