LDAR-Sim / LDAR_Sim

MIT License
11 stars 20 forks source link

Ldar 52 update the e2 e run script #285

Closed ThomasGalesloot closed 1 month ago

ThomasGalesloot commented 1 month ago

Pull Request Key Information

Reason for change

The end-to-end test runner script was long, hard to maintain and did not share code with other scripts that "run" LDAR-Sim.

What was changed

Refactored the end-to-end test runner script to use an end-to-end test runner simulation manager that inherits core functionality from the base simulation manager.

Intended Purpose

This allows the end-to-end test runner simulation manager to inherit changes made to LDAR-Sim run functionality.

Level of version change required

N/A

Testing Completed

All E2E tests pass: V4_simple_non_repairable_emissions_b9494d55c4654f1f1128c498423dcee712564eca.log V4-simple_repairable_emissions_b9494d55c4654f1f1128c498423dcee712564eca.log

All unit tests pass: unit_test_results.txt

Target Issue

N/A

Additional Information

N/A

ThomasGalesloot commented 1 month ago

E2E testing results on latest commit: V4_simple_non_repairable_emissions_59f22255ceb882ba74b6383ef976eac8a9e24dcf.log V4-simple_repairable_emissions_59f22255ceb882ba74b6383ef976eac8a9e24dcf.log

ThomasGalesloot commented 1 month ago

Latest E2E testing results: V4-simple_repairable_emissions_a7094b1da1431c28aeac50bc4bf2badddb17f757.log V4_simple_non_repairable_emissions_a7094b1da1431c28aeac50bc4bf2badddb17f757.log

ThomasGalesloot commented 1 month ago

Latest End-to-End testing results: V4-simple_repairable_emissions_e39b0de35041486801d2a3e605ffd6503f0d308d.log V4_simple_non_repairable_emissions_e39b0de35041486801d2a3e605ffd6503f0d308d.log