LDAR-Sim / LDAR_Sim

MIT License
11 stars 22 forks source link

feat: Add logging for runtime errors #290

Closed ThomasGalesloot closed 2 months ago

ThomasGalesloot commented 2 months ago

Pull Request Key Information

Reason for change

LDAR-Sim runtime error messages are not logged, making it difficult to debug issues that occur during runtime.

What was changed

This change adds logging for runtime errors to make it easier to identify and resolve issues.

Intended Purpose

Runtime errors will be logged to the error file.

Level of version change required

N/A

Testing Completed

Manually tested using parameters and inputs from simple test case1. An alteration was made to the virtual world: infrastructure parameters such that the sites file pointed to a file that did not exist so the simulation would encounter a FileNotFoundError. Manually verified the error was logged to the error log.

All unit tests pass: unit_test_results.txt

All E2E tests pass: V4_simple_non_repairable_emissions_2d531627e50dc78d9d44ef8e70224b36abc25722.log V4-simple_repairable_emissions_2d531627e50dc78d9d44ef8e70224b36abc25722.log

Target Issue

N/A

Additional Information

N/A

ThomasGalesloot commented 2 months ago

Latest E2E test results: V4_simple_non_repairable_emissions_70105047c0c05c1abdf5fb13221cf291cbeaca96.log V4-simple_repairable_emissions_70105047c0c05c1abdf5fb13221cf291cbeaca96.log

Latest Unit testing results: unit_test_results.txt