Rolling averages in LDAR-Sim were not behaving as expected, as the rolling average calculation began only when a rate above the threshold was detected. Additionally, the rolling average began calculating before the requisite window.
What was changed
Updated rolling average logic to compute true rolling averages from day 1 of the simulation. Rolling averages will only begin to register after window days have passed.
Intended Purpose
More accurate representation of rolling average behavior.
Pull Request Key Information
Reason for change
Rolling averages in LDAR-Sim were not behaving as expected, as the rolling average calculation began only when a rate above the threshold was detected. Additionally, the rolling average began calculating before the requisite window.
What was changed
Updated rolling average logic to compute true rolling averages from day 1 of the simulation. Rolling averages will only begin to register after window days have passed.
Intended Purpose
More accurate representation of rolling average behavior.
Level of version change required
Minor version bump
Testing Completed
All unit tests pass: unit_test_results.txt
E2E tests need to be updated so will not be tested.
Vigorous manual testing complete using specific engineered scenarios to test rolling average behavior.
Target Issue
N/A
Additional Information
N/A