Open tbarchyn opened 1 year ago
From my understanding, they were not added to the default parameters because they are only used for satellites, so it was determined users who want to parameterize satellites could always add these parameters.
Tests will definitely have to be done before these parameters are added
TLE_label
andTLE_file
are satellite method specific parameters that govern the orbit of the satellite, defined here:https://github.com/LDAR-Sim/LDAR_Sim/blob/master/USER_MANUAL.md#tle_file-satellite-only
They are not in the default method parameters here:
https://github.com/LDAR-Sim/LDAR_Sim/blob/master/LDAR_Sim/src/default_parameters/m_default.yml
They are labeled as 'optional' and of course only apply to satellite method. My inclination is to add them and run some tests to make sure they won't break any other methods (seems unlikely) and submit PR.
Was there specific reasoning why they weren't in the default parameters?