search

LDAR-Sim / LDAR_Sim

MIT License
11 stars 22 forks source link

Add Venting and Leak File inputs for subtypes #52

Closed ThomasGalesloot closed 1 year ago

ThomasGalesloot commented 1 year ago

Added the option in the subtype file to provide venting and leak file inputs to sample from to inform vent and leak rates respectively.

Reason for change: Previously, sampling from leak rates was only possible at a program level. To increase simulation accuracy, it has been requested that the ability to sample at a subtype level should be added. For venting, sampling at a subtype level is also desired as an alternative to provided site level static venting rates.

Closes #43

All E2E tests are passing: testing_logs.zip

ThomasGalesloot commented 1 year ago

3 questions:

  1. Should this be split into 2 PR's, one for leak files in the subtype file and 1 for vent files in the subtype file?
  2. Should I upload another subtype_distributions file in the inputs folder to serve as an example?
  3. As unit testing these code changes is difficult, should I add new end to end test(s) to test this functionality?
SEAJang commented 1 year ago
  1. One PR is fine I think just because they build on the same feature
  2. Another example that showcases the feature added is always useful. So yes.
  3. Yes.
ThomasGalesloot commented 1 year ago

Sally's concerns/comments have now been addressed. Ready for review.