search

LDMX-Software / Ecal

Software module for digitizing, reconstructing, and vetoing within the ECal.
1 stars 0 forks source link

Some veto variables are no longer calculated in reconstruction #46

Closed bryngemark closed 1 year ago

bryngemark commented 1 year ago

Since at least v3.2.0, there are no containment variables, recoil electron px/y/z, etc being calculated for signal and I can't see that there are any reconstruction differences at the config level between signal and e.g. Ecal PN, which does have them. Please prove me wrong but this looks like a bug.

bryngemark commented 1 year ago

For instance I wonder if this is still true: https://github.com/LDMX-Software/ldmx-sw/blob/71d0552208bcbaf499478932feb382a7141c89cf/Tools/src/Tools/AnalysisUtils.cxx#L31 ... I have a feeling there might have been subtle changes to signal generation lately.

bryngemark commented 1 year ago

I suppose @tomeichlersmith might be the person to ask about that

tomeichlersmith commented 1 year ago

Yep :face_with_head_bandage: the recoil electron no longer always as track ID == 1.

We will need to update that function to search the particle map for the electron whose creator processes is eDarkBrem. e.g.

https://github.com/LDMX-Software/ldmx-analysis/blob/5daa769dbdd190857a0c3422a330a0f75cc765b2/src/Analysis/EaT/DarkBremKinematics.cxx#L120-L122

tomeichlersmith commented 1 year ago

Resolved by https://github.com/LDMX-Software/ldmx-sw/pull/1154