search

LDMX-Software / G4DarkBreM

Dark Bremmstrahlung in Geant4 with MadGraph event libraries.
https://ldmx-software.github.io/G4DarkBreM/
Apache License 2.0
0 stars 1 forks source link

Comments on G4DarkBremstrahlung.cxx #5

Closed jmmans closed 1 year ago

jmmans commented 1 year ago

Should this be G4cout or something else which isn't a manditory output (or controlled by a #define for verbosity)? https://github.com/tomeichlersmith/G4DarkBreM/blob/c8a9ccf2018f84bd0a8f824f352b8ef2383b0c44/src/G4DarkBreM/G4DarkBremsstrahlung.cxx#L51 Please search for all use of cout here and make sure you're doing what is reasonable. For example, old debugging couts can go.

Should this magic number be defined in a header or somehow determined in a way that it doesn't break in the future without warning? https://github.com/tomeichlersmith/G4DarkBreM/blob/c8a9ccf2018f84bd0a8f824f352b8ef2383b0c44/src/G4DarkBreM/G4DarkBremsstrahlung.cxx#L30

This method seems like it could use a little more documentation: https://github.com/tomeichlersmith/G4DarkBreM/blob/c8a9ccf2018f84bd0a8f824f352b8ef2383b0c44/src/G4DarkBreM/G4DarkBremsstrahlung.cxx#L148

tomeichlersmith commented 1 year ago

Resolved with 6b60cdfdf8fbaa5d872c07c642093bfa57cc0462, 7a1da3ef199e7ac314619ddccf126a8a804ab8b7, and b8752ab49853684018f34eda73180a919e86b494